[REVIEW] Add cudf::dictionary::make_dictionary_pair_iterator #6651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6651 +/- ##
============================================
Coverage 82.33% 82.33%
============================================
Files 94 94
Lines 15369 15369
============================================
Hits 12654 12654
Misses 2715 2715 Continue to review full report at Codecov.
|
This was referenced Nov 4, 2020
davidwendt
commented
Nov 5, 2020
jrhemstad
approved these changes
Nov 5, 2020
codereport
approved these changes
Nov 5, 2020
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2020
Reference #5963 This PR adds dictionary column type support to the set of `cudf::reduce` functions. This PR depends on utilities added in PR #6651 Here are the reduce operations that will be included in this PR. - [x] all - [x] any - [x] max - [x] mean - [x] median - [x] min - [x] nth_element - [x] product - [x] quantile - [x] std - [x] sum_of_squares - [x] sum - [x] unique_count - [x] var Authors: - davidwendt <[email protected]> Approvers: - Mike Wendt - AJ Schmidt - Ram (Ramakrishna Prabhu) - Karthikeyan URL: #6666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pair iterator for dictionary column types that returns key/valid pairs for each row access.
This is useful in PR #6585 and will be useful in supporting dictionary type columns in
cudf::reduce.This PR also adds an
cudf::is_dictionarytotraits.hppThe
cudf::is_unsignedwas declared in an odd place in thetraits.hppand so was also moved in this PR.